Back to all Tasks

Remove undefined behavior in net sockaddr usage

Remove potential undefined behavior in networking code.
Checked Out
$2,250.00
Check Out Task
Task Bounty Details

22613

Bitcoin Issue

Hours

Estimated Effort

Checked Out

Current Status

$2,250.00

Paid in USD or equivalent BTC upon acceptance

Bitcoin Issue

From the original issue:

Bitcoin code does contain UB [undefined behavior] in the net code in particular. All of the code that works with `struct sockaddr` needs to be inspected and fixed. For example here:

bitcoin/src/netaddress.cpp (Line 988 in b620b2d)

`struct sockaddr_in *paddrin = (struct sockaddr_in*)paddr;`

It is illegal/UB in C++ to do this type of aliasing and dereference a pointer that is reinterpre_casted in this way. C++ has stricter aliasing rules than C. For reference, see this: https://en.cppreference.com/w/cpp/language/reinterpret_cast#Type_aliasing

Good knowledge of C/C++ is recommended.

Prerequisite Skills

C++

Code Guidelines

Repository Code Guidelines Page

Definition of Done

Get a PR merged which closes the original issue

Check Out Task
Back to all Tasks
© 2022 NYDIG. All rights reserved.
LICENSES | PRIVACY POLICY
This website is provided for informational purposes only. None of the material on NYDIG.com is intended to be, nor does it constitute, a solicitation, recommendation or offer to buy or sell any security, financial product or instrument. You should conduct your own analysis and consult with professional advisors prior to making any investment decisions. Bitcoin investments have historically been highly volatile and are for investors with a high risk tolerance. Investors in bitcoin could lose the entire value of their investment. All statistical information is as of December 31, 2022 unless otherwise specified.‍

Only certain NYDIG legal entities or businesses are regulated. New York Digital Investment Group LLC is not overseen by any regulator. Please see the NYDIG disclosures or terms and conditions for the particular service or transaction for more details. NYDIG Execution LLC (NMLS ID: 1781446) is licensed to engage in Virtual Currency Business Activity by the New York State Department of Financial Services. NYDIG Trust Company LLC (NMLS ID: 1985471) is chartered as a limited purpose trust company by the New York State Department of Financial Services. Full-Service Brokerage refers to bitcoin trading services provided by NYDIG Execution LLC and NYDIG Trust Company LLC; neither entity is registered as a broker-dealer with the SEC or FCM with the NFA or CFTC. NYDIG Trust Company LLC does business under registered dba names in various states as disclosed here. NYDIG, NY\DIG, and NEW YORK DIGITAL INVESTMENT GROUP are registered trademarks of NYDIG.